Fix RealVect crossProduct #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think with |
Member
|
Oh I didn't realize that the failed tests were still using an old version
of amrex. No wonder those error messages didn't make sense. Anyway, please
revert my changes because it is too complicated.
…On Tue, May 13, 2025, 1:45 AM Alexander Sinn ***@***.***> wrote:
*AlexanderSinn* left a comment (AMReX-Codes/pyamrex#445)
<#445 (comment)>
I think with .def("crossProduct", &RealVect::crossProduct<>, it also
worked with amrex development but not amrex release. I only converted about
half the CI tests to development. But with pyamrex_realvect_crossproduct
it works with both versions.
—
Reply to this email directly, view it on GitHub
<#445 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB37TYK2NPAKJQJU5SFISBL26GWK3AVCNFSM6AAAAAB46ZZBA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZVGU4DEMBWGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
WeiqunZhang
approved these changes
May 13, 2025
Member
|
Should we switch to using amrex development in CI? |
Member
Author
|
Probably should. However, I don't know how to change the amrex branch in the tests where pyamrex is compiled with pip |
Member
|
That might be difficult. |
Member
|
@WeiqunZhang @AlexanderSinn I rather would, as in other projects, add pyAMReX to the app tests in AMReX and then manually update here the commits weekly (and on demand for breaking PRs). That gives us more control |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for AMReX-Codes/amrex#4430